Re: [PATCHv2 03/24] sys_swapon: do not depend on "type" after allocation

From: Pekka Enberg
Date: Sat Mar 05 2011 - 12:07:18 EST


On Sat, Mar 5, 2011 at 6:42 PM, Cesar Eduardo Barros <cesarb@xxxxxxxxxx> wrote:
> Within sys_swapon, after the swap_info entry has been allocated, we
> always have type == p->type and swap_info[type] == p. Use this fact to
> reduce the dependency on the "type" local variable within the function,
> as a preparation to move the allocation of the swap_info entry to a
> separate function.
>
> Signed-off-by: Cesar Eduardo Barros <cesarb@xxxxxxxxxx>
> Tested-by: Eric B Munson <emunson@xxxxxxxxx>
> Acked-by: Eric B Munson <emunson@xxxxxxxxx>

Reviewed-by: Pekka Enberg <penberg@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/