Re: [RFC PATCH] net/core: fix skb handling on netif serves for bothbridge and vlan

[Nicolas de Pesloüan]

Le 05/03/2011 11:36, Jiri Pirko a écrit :
> Thu, Mar 03, 2011 at 11:55:13AM CET, dfeng@xxxxxxxxxx wrote:
> > Consider network topology as follows:
> >
> > eth0  eth1
> > |_____|
> >     |
> >   bond0 --- br0
> >     |
> >   vlan0 --- br1
> >
> > bond0 serves for both br0 and vlan0, if a vlan tagged packet was sent
> > to br1 through bond0, bridge handling code is seeing the packet on bond0
> > and handing it off to my "legacy" bridge before vlan_tx_tag_present
> > and vlan_hwaccel_do_receive even haven't a chance to look at it.
> >
> > Moving the vlan_tx_tag_present before bridge/macvlan handling code could
> > cure this.
>
> Wouldn't this break "eth0 - br0 - br0.5"?

I think it would. One more reason to build a single interface stacking framework...

	Nicolas.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/