Re: [PATCH v3] Check for immutable/append flag in fallocate path

[Sedat Dilek]

On 3/5/11, Marco Stornelli <marco.stornelli@xxxxxxxxx> wrote:
> From: Marco Stornelli <marco.stornelli@xxxxxxxxx>
>
> In the fallocate path the kernel doesn't check for the immutable/append
> flag. It's possible to have a race condition in this scenario: an
> application open a file in read/write and it does something, meanwhile
> root set the immutable flag on the file, the application at that point
> can call fallocate with success. In addition, we don't allow to do any
> unreserve operation on an append only file but only the reserve one.
>
> Signed-off-by: Marco Stornelli <marco.stornelli@xxxxxxxxx>
> ---
> Patch is against 2.6.38-rc7
>
> ChangeLog:
> v3: Modified do_fallocate instead of every single fs
> v2: Added the check for append-only file for XFS
> v1: First draft
>
> --- open.c.orig	2011-03-01 22:55:12.000000000 +0100
> +++ open.c	2011-03-04 15:28:43.000000000 +0100

Shouldn't that be sth like...?

--- linux-2.6.38-rc7.orig/fs/open.c
+++ linux-2.6.38-rc7/fs/open.c

- Sedat -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/