Re: linux-next: Tree for February 21 (usb/serial)

From: Alan Stern
Date: Fri Mar 04 2011 - 10:04:47 EST


On Thu, 3 Mar 2011, Randy Dunlap wrote:

> On Mon, 21 Feb 2011 21:30:01 +0100 Rafael J. Wysocki wrote:
>
> > On Monday, February 21, 2011, Randy Dunlap wrote:
> > > On Mon, 21 Feb 2011 18:21:34 +1100 Stephen Rothwell wrote:
> > >
> > > > Hi all,
> > > >
> > > > Changes since 20110218:
> > >
> > >
> > > When CONFIG_PM_RUNTIME is not enabled:
> > >
> > > drivers/usb/serial/usb_wwan.c:702: error: 'struct dev_pm_info' has no member named 'usage_count'
> >
> > This looks like a bug in the driver that shouldn't access this field directly.
>
>
> This build error is still with us in linux-next 2011.0303.

Since Oliver added this bug in commit
16871dcac74c63227aa92e0012f3004a648c2062 (usb_wwan: error case of
resume), he should be the person to fix it. The logic there is not
clear to me; I don't know how it ought to be changed. Would replacing
it with a call to usb_autopm_put_interface_no_suspend() be good enough?

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/