Re: [PATCHv2 1/7] x86: remove superflous goal definition of tsc_sync
From: Cyrill Gorcunov
Date: Fri Mar 04 2011 - 07:43:17 EST
On Fri, Mar 4, 2011 at 2:58 PM, Henrik Kretzschmar
<henne@xxxxxxxxxxxxxxxx> wrote:
> This goal definition is superflous.
> CONFIG_X86_64_SMP depends on CONFIG_SMP
> and tsc_sync.o is already in the definition of CONFIG_SMP.
>
> Signed-off-by: Henrik Kretzschmar <henne@xxxxxxxxxxxxxxxx>
> ---
> arch/x86/kernel/Makefile | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kernel/Makefile b/arch/x86/kernel/Makefile
> index 4ad4509..6b61081 100644
> --- a/arch/x86/kernel/Makefile
> +++ b/arch/x86/kernel/Makefile
> @@ -69,7 +69,6 @@ obj-$(CONFIG_APM) += apm.o
> obj-$(CONFIG_SMP) += smp.o
> obj-$(CONFIG_SMP) += smpboot.o tsc_sync.o
> obj-$(CONFIG_SMP) += setup_percpu.o
> -obj-$(CONFIG_X86_64_SMP) += tsc_sync.o
> obj-$(CONFIG_X86_MPPARSE) += mpparse.o
> obj-y += apic/
> obj-$(CONFIG_X86_REBOOTFIXUPS) += reboot_fixups_32.o
> --
> 1.7.2.3
>
>
Probably we better write it this way:
- obj-$(CONFIG_SMP) += smpboot.o tsc_sync.o
- obj-$(CONFIG_X86_64_SMP) += tsc_sync.o
+ obj-$(CONFIG_SMP) += smpboot.o
+ obj-$(CONFIG_SMP) += tsc_sync.o
I guess this would be cleaner? Ingo?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/