Re: [PATCH 09/27] nfs: writeback pages wait queue

[Peter Zijlstra]

On Fri, 2011-03-04 at 10:01 +0800, Wu Fengguang wrote:
>                         clear_bdi_congested(bdi, BLK_RW_SYNC);
>                         /*
>                          * On the following wake_up(), nfs_wait_congested()
>                          * will see the cleared bit and quit.
>                          */
>                         smp_mb__after_clear_bit();
>                 }
>                 if (waitqueue_active(&wqh[BLK_RW_SYNC]))
>                         wake_up(&wqh[BLK_RW_SYNC]); 

If I tell you that: try_to_wake_up() implies an smp_wmb(), do you then
still need this?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/