Re: [PATCH v4] hwmon: Add support for Texas Instruments ADS1015

[Wolfram Sang]

> > +#ifdef CONFIG_OF
> > +	/* fallback on OF */
> > +	of_channels = of_get_property(np, "exported-channels",
> > +				      &of_channels_size);
> > +	if (of_channels && (of_channels_size == sizeof(*of_channels)))
> > +		return be32_to_cpup(of_channels);
> > +#endif
> 
> The be32 thing looks odd. I don't get the idea, but as I don't know
> much about devicetree, I'll trust you.

That's okay. The properties are be32 (coming from powerpc).

Still, there is a new property defined which _always_ needs

a) CCing devicetree-discuss (get_maintainer helps here)
b) Documentation in Documentation/devicetree/bindings

because it needs to be a lot more stable than platform_data.

(I already lost the original mail, so I sadly can't forward it)

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Attachment: signature.asc
Description: Digital signature