Re: [PATCH 2/2] mm: compaction: Minimise the time IRQs are disabledwhile isolating pages for migration

From: KAMEZAWA Hiroyuki
Date: Mon Feb 28 2011 - 18:48:40 EST


On Mon, 28 Feb 2011 10:18:27 +0000
Mel Gorman <mel@xxxxxxxxx> wrote:

> > BTW, can't we drop disable_irq() from all lru_lock related codes ?
> >
>
> I don't think so - at least not right now. Some LRU operations such as LRU
> pagevec draining are run from IPI which is running from an interrupt so
> minimally spin_lock_irq is necessary.
>

pagevec draining is done by workqueue(schedule_on_each_cpu()).
I think only racy case is just lru rotation after writeback.

Thanks,
-Kame

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/