Re: [PATCH v4 2/2] Defines DA850/AM18xx/OMAPL1-38 SOC resources usedby PRUSS UIO driver

[Sergei Shtylyov]

Hello.

On 28-02-2011 7:46, TK, Pratheesh Gangadhar wrote:

> > > This patch defines PRUSS, ECAP clocks, memory and IRQ resources
> > > used by PRUSS UIO driver in DA850/AM18xx/OMAPL1-38 devices. UIO

> >      It's OMAP-L138.
> Ok.

> > > driver exports 64K I/O region of PRUSS, 128KB L3 RAM and 256KB
> > > DDR buffer to user space. PRUSS has 8 host event interrupt lines
> > > mapped to IRQ_DA8XX_EVTOUT0..7 of ARM9 INTC.These in conjunction
> > > with shared memory can be used to implement IPC between ARM9 and
> > > PRUSS.

> > > Signed-off-by: Pratheesh Gangadhar<pratheesh@xxxxxx>

[...]

> > > diff --git a/arch/arm/mach-davinci/devices-da8xx.c b/arch/arm/mach-
> > davinci/devices-da8xx.c
> > > index beda8a4..4ea3d1f 100644
> > > --- a/arch/arm/mach-davinci/devices-da8xx.c
> > > +++ b/arch/arm/mach-davinci/devices-da8xx.c
> > > @@ -725,3 +725,76 @@ int __init da8xx_register_cpuidle(void)
> > >
> > >    	return platform_device_register(&da8xx_cpuidle_device);
> > >    }
> > > +static struct resource pruss_resources[] = {
> > > +	[0] = {
> > > +		.start  = DA8XX_PRUSS_BASE,
> > > +		.end    = DA8XX_PRUSS_BASE + SZ_64K - 1,
> > > +		.flags  = IORESOURCE_MEM,
> > > +	},
> > > +	[1] = {
> > > +		.start  = DA8XX_L3RAM_BASE,
> > > +		.end    = DA8XX_L3RAM_BASE + SZ_128K - 1,
> > > +		.flags  = IORESOURCE_MEM,
> > > +	},
> > > +	[2] = {
> > > +		.start  = 0,
> > > +		.end    = SZ_256K - 1,

> >      Huh? I don't see where it's filled...

> The current use is only to indicate memory block size to the PRUSS UIO driver when we allocate DDR memory using dma_alloc_coherent.

   Why not pass this size via the platform data? There shouldn't be "dummy" 
resources.

> sram_alloc is changed to use L3_RAM (128KB) instead of ARM RAM (8KB) in Mistral patch set - I need to follow the same convention
> for L3 RAM as well if I need to align with that patch. Is there a better 
way to do this?

   Didn't understand about L3 RAM.
   Also, please wrap your text at 80 columns.

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/