Re: [PATCH v2] tpm_tis: Use timeouts returned from TPM

[Stefan Berger]

On 02/26/2011 06:45 AM, Jiri Slaby wrote:
> On 02/22/2011 08:41 PM, Stefan Berger wrote:
> > Below patch applies to the tip of the git tree.
> >
> > v2:
> >    - adjusting all timeouts for TPM devices reporting too low timeout
> > numbers
> >    - also displaying in sysfs whether the timeouts are 'original' or
> > 'adjusted'
> >
> > The current TPM TIS driver in git discards the timeout values returned
> > from the TPM. The check of the response packet needs to consider that
> > the return_code field is 0 on success and the size of the expected
> > packet is equivalent to the header size + u32 length indicator for the
> > TPM_GetCapability() result + 3 timeout indicators of type u32.
> >
> > Since some TPMs seem to return timeouts in msec rather than usec,
> > I am now adjusting all the timeouts rather than just the one for short
> > durations.
> >
> > I am also adding a sysfs entry 'timeouts' showing the timeouts that are
> > being used.
> It works:
'It' means also 'suspend' works?


> # dmesg
> [15318.813905] tpm_tis 00:0c: 1.2 TPM (device-id 0xB, rev-id 16)
> [15318.879154] tpm_tis 00:0c: Adjusting TPM timeout parameters.
> # cat /sys/devices/pnp0/00\:0*/timeouts
> 1000000 2000000 150000000 [adjusted]
Looks more reasonable.

   Stefan

> thanks,

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/