RE: [PATCH 11/12] unicore32 machine related files: ps2 driver

[Guan Xuetao]

> -----Original Message-----
> From: Arnd Bergmann [mailto:arnd@xxxxxxxx]
> Sent: Wednesday, February 23, 2011 1:12 AM
> To: Guan Xuetao
> Cc: dmitry.torokhov@xxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-arch@xxxxxxxxxxxxxxx; 'Greg KH'
> Subject: Re: [PATCH 11/12] unicore32 machine related files: ps2 driver
> 
> On Tuesday 22 February 2011, Guan Xuetao wrote:
> > diff --git a/drivers/input/serio/i8042-unicore32io.h b/drivers/input/serio/i8042-unicore32io.h
> > index 2cdd872..9350843 100644
> > --- a/drivers/input/serio/i8042-unicore32io.h
> > +++ b/drivers/input/serio/i8042-unicore32io.h
> > @@ -29,11 +29,11 @@
> >  /*
> >   * Register numbers.
> >   */
> > -#define I8042_COMMAND_REG      ((volatile void __iomem *)&PS2_COMMAND)
> > -#define I8042_STATUS_REG       ((volatile void __iomem *)&PS2_STATUS)
> > -#define I8042_DATA_REG         ((volatile void __iomem *)&PS2_DATA)
> > +#define I8042_COMMAND_REG      PS2_COMMAND
> > +#define I8042_STATUS_REG       PS2_STATUS
> > +#define I8042_DATA_REG         PS2_DATA
> 
> I wouldn't bother defining two sets of macros then. Either use PS2_COMMAND
> in the driver, or define I8042_COMMAND_REG in the place where you currently
> define PS2_COMMAND.
All I8042_*_REGs are explicitly defined in i8042-*io.h files.
And I want to reserve the original register names in unicore32 namespace.
> 
> Aside from this, it looks good.
> 
> 	Arnd
Thanks & Regards.
Guan Xuetao

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/