Re: [PATCH v4 3/5] hwmon: (pmbus) Add support for Maxim MAX16064

From: Guenter Roeck
Date: Fri Feb 25 2011 - 16:43:54 EST


Hi Jonathan,

On Fri, 2011-02-25 at 15:26 -0500, Jonathan Cameron wrote:
> Again, straight forward use of pmbus_core. Is it actually worth having
> separate modules for each of these special cases? Could just do the
> old big table of fixed chip info structures in a single driver...
>
This is actually what I had originally. My reasoning to split it up was
that this makes it easier to add support for additional chips without
having to modify the core driver. Also, I can keep chip specific code
(specifically the _identify and _get_status functions) out of the core
driver.

Thanks,
Guenter


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/