Re: [PATCH RESEND 1/1] Cleanup of asm-offsets.c(PAGE_SIZE_asm, PAGE_SHIFT_asm,THREAD_SIZE_asm)

[H. Peter Anvin]

On 02/25/2011 12:03 PM, Stratos Psomadakis wrote:
> Cleanup of asm-offsets.c.
> 
> PAGE_SIZE_asm, PAGE_SHIFT_asm, THREAD_SIZE_asm can be safely removed from 
> asm-offsets.c, and be replaced by their non-'_asm' counterparts in the code 
> that uses them, since the _AC macro defined in include/linux/const.h makes
> PAGE_SIZE/PAGE_SHIFT/THREAD_SIZE work with as.
> 
> Signed-off-by: Stratos Psomadakis <psomas@xxxxxxxxxxxxxxxxx>
> ---
>  arch/mn10300/kernel/asm-offsets.c      |    2 --
>  arch/mn10300/kernel/gdb-io-ttysm-low.S |    2 +-
>  arch/x86/kernel/asm-offsets_32.c       |    4 ----
>  arch/x86/kernel/asm-offsets_64.c       |    1 -
>  arch/x86/kernel/entry_32.S             |    2 +-
>  arch/x86/kernel/head_32.S              |    8 ++++----
>  arch/x86/xen/xen-head.S                |    4 ++--
>  7 files changed, 8 insertions(+), 15 deletions(-)
> 

Looks good, but please separate the mn10300 and x86 chunks into separate
patches.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/