Re: [PATCH] Network driver for PMC-Sierra MSP71xx TSMAC.

[Stephen Hemminger]

On Thu, 24 Feb 2011 17:27:40 +0530
"Anoop P.A" <anoop.pa@xxxxxxxxx> wrote:
> +const char version[] = "pmcmsp_tsmac.c:v2.0 01/09/2007, PMC-Sierra\n";
> +const char cardname[] = "pmcmsp_tsmac";

All data and functions that are only used by this driver should be marked static.

> +const char drv_reldate[] = "$Date: 2010/07/15 07:38:59 $";
> +const char drv_file[] = __FILE__;

This is bogus noise.


-- 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/