Re: [PATCH 9/9] userns: check user namespace for task->file uidequivalence checks

From: Andrew Morton
Date: Thu Feb 24 2011 - 00:08:46 EST


On Thu, 24 Feb 2011 03:24:16 +0000 "Serge E. Hallyn" <serge@xxxxxxxxxx> wrote:

> Quoting Andrew Morton (akpm@xxxxxxxxxxxxxxxxxxxx):
> > On Thu, 17 Feb 2011 15:04:07 +0000
> > "Serge E. Hallyn" <serge@xxxxxxxxxx> wrote:
> >
> > There's a fairly well adhered to convention that global symbols (and
> > often static symbols) have a prefix which identifies the subsystem to
> > which they belong. This patchset rather scorns that convention.
> >
> > Most of these identifiers are pretty obviously from the capability
> > subsystem, but still...
>
> Would 'inode_owner_or_capable' be better and and make sense?
>

I suppose so. We've totally screwed that pooch in the VFS (grep EXPORT
fs/inode.c). But it's never to late to start.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/