Re: [RFC PATCH 02/10] MIPS: Octeon: Add device tree source files.

[David Daney]

On 02/23/2011 06:14 PM, David Gibson wrote:
> On Wed, Feb 23, 2011 at 05:57:43PM -0800, David Daney wrote:
> > On 02/23/2011 03:49 PM, David Gibson wrote:
> > > On Wed, Feb 23, 2011 at 11:06:30AM -0800, David Daney wrote:
> > > > On 02/22/2011 04:07 PM, David Gibson wrote:
> > > > > On Tue, Feb 22, 2011 at 12:57:46PM -0800, David Daney wrote:
> > > > > > Signed-off-by: David Daney<ddaney@xxxxxxxxxxxxxxxxxx>
> > > > > > ---
> > > > > >   arch/mips/cavium-octeon/.gitignore      |    2 +
> > > > > >   arch/mips/cavium-octeon/Makefile        |   13 ++
> > > > > >   arch/mips/cavium-octeon/octeon_3xxx.dts |  314 +++++++++++++++++++++++++++++++
> > > > > >   arch/mips/cavium-octeon/octeon_68xx.dts |   99 ++++++++++
> > > > > >   4 files changed, 428 insertions(+), 0 deletions(-)
> > > > > >   create mode 100644 arch/mips/cavium-octeon/.gitignore
> > > > > >   create mode 100644 arch/mips/cavium-octeon/octeon_3xxx.dts
> > > > > >   create mode 100644 arch/mips/cavium-octeon/octeon_68xx.dts
> > > > > >
> > > > > > diff --git a/arch/mips/cavium-octeon/.gitignore b/arch/mips/cavium-octeon/.gitignore
> > > > > > new file mode 100644
> > > > > > index 0000000..39c9686
> > > > > > --- /dev/null
> > > > > > +++ b/arch/mips/cavium-octeon/.gitignore
> > > > > > @@ -0,0 +1,2 @@
> > > > > > +*.dtb.S
> > > > >
> > > > > .dtb.S?
> > > >
> > > > I think I have the correct .gitignore syntax.
> > >
> > > What I meant was, where are you generating .dtb.S files that you need
> > > to ignore them?
> >
> > They are a byproduct of $(call cmd,dtc).
> >
> > Normally make removes them automatically, but if you abort at just
> > the right time, they can be left around.
> >
> > If it is objectionable, I can just remove that .gitignore bit.
>
> No, if they're byproducts of cmd,dtc they should be there.  I'm just a
> bit baffled as to why cmd,dtc would produce such byproducts.  dtc
> itself will convert dts ->  dtb without any extraneous intermediate
> steps.

I misspoke.

$(call cmd,dtc) does indeed just do the direct conversion.  There are 
other rules in scripts/Makefile.lib that convert the .dtb into a .dtb.o 
file that generate the .dtb.S files.

David Daney
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/