Re: [PATCH 1/4] staging: hv: Fix the code depending on structvmbus_driver_context data order

[Greg KH]

On Wed, Feb 23, 2011 at 10:55:12PM +0000, Haiyang Zhang wrote:
> > From: Greg KH [mailto:greg@xxxxxxxxx]
> > The layering is almost ok, there is still one more layer here than is
> > needed, and it should be removed (I already removed lots of layers that
> > were not needed, just didn't get to this one.)  But the naming also
> > needs to be fixed up as it is wrong from a "driver model" standpoint
> > with the rest of the kernel.
> 
> So, how about rename the "struct driver_context" to "struct gen_drv_ctx"
> in this patch? We can deal with the layering in next round of patches.

No, it's not a "driver context" at all.  It is a "hyperv driver", so
name it as such.

A "context" is a void pointer or something that the driver uses
privately.  And you already have a pointer to the context in the base
structure so you don't need your own.

You should work on removing the layering now, that will clean this all
up.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/