Re: [RFC] [PATCH 0/10] Generic Watchdog Timer Driver

From: Mike Waychison
Date: Wed Feb 23 2011 - 17:19:28 EST


On 02/23/11 12:41, Wim Van Sebroeck wrote:
Hi All,

To reduce copying the same code over and over in each watchdog device driver, Alan Cox and myself constructed a new framework/API that consolidates the common watchdog timer driver functions.

This framework/API consists of the following patches:
part 1: Introduction of the WatchDog Timer Driver Core
part 2: Add the basic ioctl functionality
part 3: Add the WDIOC_KEEPALIVE ioctl
part 4: Add the WDIOC_SETOPTIONS ioctl
part 5: Add the WDIOC_SETTIMEOUT and WDIOC_GETTIMEOUT ioctl
part 6: Add orphan control
part 7: Add the Magic Close feature
part 8: Add the nowayout feature
part 9: Add support for a miscdev parent device
part 10: Add support for extra ioctl calls

Note: I still need to add the minimum and maximum timeout parameters.
(That will become part 11).

Overall, this looks really good IMO. It goes a long way to setting the stage for cleaning up the watchdog drivers themselves :)

Reviewed-by: Mike Waychison <mikew@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/