Re: [PATCH] jump label: introduce static_branch() interface

From: Steven Rostedt
Date: Wed Feb 23 2011 - 08:45:16 EST


On Wed, 2011-02-23 at 11:11 +0100, Peter Zijlstra wrote:
> On Tue, 2011-02-22 at 17:28 -0500, Jason Baron wrote:
> > @@ -33,7 +28,11 @@ struct _ddebug {
> > #define _DPRINTK_FLAGS_PRINT (1<<0) /* printk() a message using
> > the format */
> > #define _DPRINTK_FLAGS_DEFAULT 0
> > unsigned int flags:8;
> > - char enabled;
> > +#ifdef HAVE_JUMP_LABEL
> > + struct jump_label_key enabled;
> > +#else
> > + int enabled;
> > +#endif
> > } __attribute__((aligned(8)));
> >
>
> Also, didn't you promise Mathieu a comment explaining why dynamic debug
> does funny things like this? :-) I mean we all know its because of the
> cyclic header stuff involving atomic etc.. but I'm also quite sure we'll
> all have forgotten about that in a few weeks time.

Case in point.... I already forgot about that ;-)

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/