Re: [PATCH] msm: add single-wire serial bus interface (SSBI) driver

From: Nicolas Pitre
Date: Tue Feb 22 2011 - 22:21:40 EST


On Tue, 22 Feb 2011, David Brown wrote:

> On Tue, Feb 22 2011, Nicolas Pitre wrote:
>
> > And if someone else comes up with a SSBI interface, then it will be much
> > easier to notice the already existing driver if it is in the driver
> > directory rather than somewhere else in some unrelated (from that
> > person's pov) obscure directory.
>
> Well, I'm fairly sure that nobody would be making an SSBI interface, but
> point taken.

It's not necessarily the SSBI interface per se that is interesting to
other people, but rather the fact that the code driving it might be
relying upon generic kernel infrastructure, such as driver or bus
registration, interrupt requests, resource allocation, etc.

> So what kinds of things constitute drivers versus arch-specific code?
> Currently, iommu drivers seem to be sprinkled throughout arch.

Yes, and so are clock source and clock event "drivers". Some things
fall into a gray area and this is not always clear what the proper
location is for them. But as a rule of thumb you should follow what
most other people did, and if there is no example to follow then just go
with drivers/msm/ by default which should be a pretty safe bet.


Nicolas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/