Re: [PATCH RFC tip/core/rcu 11/11] rcu: move TREE_RCU from softirqto kthread

From: Frederic Weisbecker
Date: Tue Feb 22 2011 - 22:09:53 EST


On Tue, Feb 22, 2011 at 05:39:40PM -0800, Paul E. McKenney wrote:
> +/*
> + * Set the per-rcu_node kthread's affinity to cover all CPUs that are
> + * served by the rcu_node in question.
> + */
> +static void rcu_node_kthread_setaffinity(struct rcu_node *rnp)
> +{
> + cpumask_var_t cm;
> + int cpu;
> + unsigned long mask = rnp->qsmaskinit;
> +
> + if (rnp->node_kthread_task == NULL ||
> + rnp->qsmaskinit == 0)
> + return;
> + if (!alloc_cpumask_var(&cm, GFP_KERNEL))
> + return;
> + cpumask_clear(cm);
> + for (cpu = rnp->grplo; cpu <= rnp->grphi; cpu++, mask <<= 1)

There seem to be the same shift problem here.

> + if (mask & 01)
> + cpumask_set_cpu(cpu, cm);
> + set_cpus_allowed_ptr(rnp->node_kthread_task, cm);
> + free_cpumask_var(cm);
> +}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/