Re: [PATCH] Fix over-zealous flush_disk when changing device size.

From: Jeff Moyer
Date: Mon Feb 21 2011 - 14:42:03 EST


NeilBrown <neilb@xxxxxxx> writes:

> -int __invalidate_device(struct block_device *bdev)
> +int __invalidate_device2(struct block_device *bdev, bool kill_dirty)
> {
> struct super_block *sb = get_super(bdev);
> int res = 0;
> @@ -1614,7 +1614,7 @@ int __invalidate_device(struct block_device *bdev)
> * hold).
> */
> shrink_dcache_sb(sb);
> - res = invalidate_inodes(sb);
> + res = invalidate_inodes(sb, kill_dirty);
> drop_super(sb);
> }
> invalidate_bdev(bdev);

Neil, I think you also need to change the EXPORT_SYMBOL from
__invalidate_device to __invalidate_device2. The floppy module won't
build without that change.

Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/