Re: [PATCH 02/20] ata_piix: unify code for programming PIO and MWDMAtimings

From: Sergei Shtylyov
Date: Mon Feb 21 2011 - 06:54:58 EST


Hello.

On 21-02-2011 14:38, Sergei Shtylyov wrote:

PIO mode is setup by different code, and it takes care of the IORDY
setting according to the PIO rules (and it gets called). DMA mode setup should
just ignore the IORDY setting as in all other sane drivers.

Well it can't ignore it - but if you mean just keep the bit as is then

Yes, I mean this.

that sounds sensible, have to see what the docs say happens if you ever
set MWDMA without IORDY.

Don't think they say anything on this matter but I can't imagine that IORDY
matters for DMA.

What it says is that IORDY enable bit has no effect when the fast timing bit is cleared. That's from ICH IDE PRM (29860004.pdf).

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/