Re: Fwd: [PATCH] MAINTAINERS: Quote non-alphanumeric emailaddresses

From: Harry Wei
Date: Mon Feb 21 2011 - 00:08:01 EST


On Mon, Feb 21, 2011 at 12:59:16PM +0800, jiaweiwei wrote:
> ---------- Forwarded message ----------
> From: Joe Perches <joe@xxxxxxxxxxx>
> Date: 2011/2/21
> Subject: Re: [PATCH] MAINTAINERS: Quote non-alphanumeric email addresses
> To: Harry Wei <jiaweiwei.xiyou@xxxxxxxxx>
> Cc: davem@xxxxxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx,
> linux-kernel@xxxxxxxxxxxxxxx, greg@xxxxxxxxx, rdunlap@xxxxxxxxxxxx,
> pavel@xxxxxx
>
>
> On Sun, 2011-02-20 at 21:59 +0800, Harry Wei wrote:
> > On Sat, Feb 19, 2011 at 08:46:54PM -0800, Joe Perches wrote:
> > > Add quotes around email address with periods and commas.
> > Hmm, what about some other conditions except
> > for periods and commas in maintainers' M:.
> > Like following:
> > 1> Character '-' in M:
>
> Dashes are not an issue.
Get it.
>
> > 2> No name of the M:
> > M: support@xxxxxxx
>
> Names and angle brackets are optional.
Ok.
>
> > 3> Messy code in M:
> > M: BenoÃt Cousson <b-cousson@xxxxxx>
>
> 8 bit characters _might_ be an issue, but
> no one has reported any problems yet.
Get it.
>
> I think you should read and understand rfc 2822
> before continuing with this.
Thanks, i will read it :)
>
> Utilities like git send-email and get_maintainer.pl
> generally provide email address parsing for only a
> subset of all valid address styles.
>
> As these utilities are done mostly by regex, not
> all valid email addresses are supported because the
> regex validations get ridiculously complicated.
>
> There are some "monster" regex classes that attempt
> to support a greater range of valid email address
> styles, but the pain of implementation generally
> isn't worth it.
>
> You're free to try to improve it of course, but I
> think that modifications to the address styles
> currently used in MAINTAINERS to remove "special"
> address style handling isn't necessary.
Get it, thanks.

Best Regards.
Harry Wei.
>
>
>
>
> --
> do kernel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/