Re: [PATCH] staging/et131x: fix et131x_rx_dma_disable halt_statususage

[Alan Cox]

On Sun, 20 Feb 2011 20:03:34 +0100
Marcin Slusarz <marcin.slusarz@xxxxxxxxx> wrote:

> Commit 1bd751c1abc1029e8a0ae63ef4f19357c735a2a3
> ("Staging: et131x: Clean up rxdma_csr") changed csr from bitfield to
> u32, but failed to convert 2 uses of halt_status bit. It did:
> 
> - if (csr.bits.halt_status != 1)
> + if ((csr & 0x00020000) != 1)
> 
> which is wrong, because second version is always true.
> Fix it.
> 
> This bug was found by coccinelle (http://coccinelle.lip6.fr/).
> 
> Signed-off-by: Marcin Slusarz <marcin.slusarz@xxxxxxxxx>
> Cc: Alan Cox <alan@xxxxxxxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxx>

Acked-by: Alan Cox <alan@xxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/