Re: [PATCH] tcp: fix inet_twsk_deschedule()

From: David Miller
Date: Sat Feb 19 2011 - 21:59:20 EST


From: Eric Dumazet <eric.dumazet@xxxxxxxxx>
Date: Sat, 19 Feb 2011 09:35:56 +0100

> [PATCH] tcp: fix inet_twsk_deschedule()
>
> Eric W. Biederman reported a lockdep splat in inet_twsk_deschedule()
>
> This is caused by inet_twsk_purge(), run from process context,
> and commit 575f4cd5a5b6394577 (net: Use rcu lookups in inet_twsk_purge.)
> removed the BH disabling that was necessary.
>
> Add the BH disabling but fine grained, right before calling
> inet_twsk_deschedule(), instead of whole function.
>
> With help from Linus Torvalds and Eric W. Biederman
>
> Reported-by: Eric W. Biederman <ebiederm@xxxxxxxxxxxx>
> Signed-off-by: Eric Dumazet <eric.dumazet@xxxxxxxxx>
> CC: Daniel Lezcano <daniel.lezcano@xxxxxxx>
> CC: Pavel Emelyanov <xemul@xxxxxxxxxx>
> CC: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> CC: stable <stable@xxxxxxxxxx> (# 2.6.33+)

Applied, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/