Re: [PATCH 3/4] cpuset: Fix unchecked calls to NODEMASK_ALLOC()

From: Paul Menage
Date: Fri Feb 18 2011 - 21:29:23 EST


On Thu, Feb 17, 2011 at 6:47 PM, Li Zefan <lizf@xxxxxxxxxxxxxx> wrote:
>
> I think a defect of this is people might call it twice in one function
> but don't know it returns the same variable?

Hopefully they'd read the comments...

But it's not a big issue either way - having the WARN_ON() statements
in front of each use works OK too, given that there are only a few of
them.

Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/