Re: [patch -next] x86, microcode, AMD: signedness bug ingeneric_load_microcode()

From: Borislav Petkov
Date: Fri Feb 18 2011 - 04:40:00 EST


On Fri, Feb 18, 2011 at 04:17:16AM -0500, Dan Carpenter wrote:
> install_equiv_cpu_table() returns type int. It uses negative error
> codes so using an unsigned type breaks the error handling.
>
> Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>

Yes, my bad, sorry.

Acked-by: Borislav Petkov <borislav.petkov@xxxxxxx>

Ingo, this should go ontop of tip/x86/microcode please, for it fixes
10de52d6655e ("x86, microcode, AMD: Simplify install_equiv_cpu_table").

Thanks a bunch.

--
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/