Re: [PATCH 0/10] Add yaffs2 file system: Fifth patchset

From: Greg KH
Date: Thu Feb 17 2011 - 19:36:48 EST


On Fri, Feb 18, 2011 at 12:01:50AM +0000, Mark Brown wrote:
> On Thu, Feb 17, 2011 at 03:41:54PM -0800, Greg KH wrote:
> > On Thu, Feb 17, 2011 at 04:49:57PM +1300, Charles Manning wrote:
>
> > > Stripping out the tracing is easy enough but pointless if people (ie those
> > > actually using yaffs) really want it. Same for the proc interface (though
> > > that could be moved to sysfs).
>
> > Use debugfs please, if it's debugging stuff. If it's "real" stuff, then
> > yes, it should be in sysfs, you already have a place for it in /sys/fs/
> > to use. Just abide by the sysfs rules and you will be fine.
>
> For the proc stuff - for tracing stuff then tracepoints are likely to be
> a good option if it's useful to people.

Then use the in-kernel tracing functionality, don't roll your own. And
that is not in /proc, so it should be there for this filesystem either.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/