Re: linux-next: build failure after merge of the tip tree

From: Ingo Molnar
Date: Thu Feb 17 2011 - 12:11:56 EST



* Michal Marek <mmarek@xxxxxxx> wrote:

> @@ -340,9 +342,16 @@ static void parse_dep_file(void *map, size_t len)
> if (strrcmp(s, "include/generated/autoconf.h") &&
> strrcmp(s, "arch/um/include/uml-config.h") &&
> strrcmp(s, ".ver")) {
> - printf(" %s \\\n", s);
> + /* Do not output the first dependency (the
> + * source file), so that kbuild is not confused
> + * if a .c file is rewritten into .S or vice
> + * versa.
> + */

Just a really minor nitpick, please use the standard comment style:

/*
* Comment .....
* ...... goes here.
*/

specified in Documentation/CodingStyle.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/