Re: [PATCH v2 09/13] can: pruss CAN driver.

[Subhasish Ghosh]

Hello,

The problem with the "all" implementation is that it hogs the ARM/DSP 
heavily and that's the reason why we specifically avoided this in our 
firmware design.
Hence, implementing this condition spoils the whole purpose of the PRU!!

--------------------------------------------------
From: "Marc Kleine-Budde" <mkl@xxxxxxxxxxxxxx>
Sent: Monday, February 14, 2011 3:05 PM
To: "Subhasish Ghosh" <subhasish@xxxxxxxxxxxxxxxxxxxx>
Cc: "Wolfgang Grandegger" <wg@xxxxxxxxxxxxxx>; "Kurt Van Dijck" 
<kurt.van.dijck@xxxxxx>; <davinci-linux-open-source@xxxxxxxxxxxxxxxxxxxx>; 
<linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>; <m-watkins@xxxxxx>; 
<nsekhar@xxxxxx>; <sachi@xxxxxxxxxxxxxxxxxxxx>; "open list:CAN NETWORK 
DRIVERS" <socketcan-core@xxxxxxxxxxxxxxxx>; "open list:CAN NETWORK DRIVERS" 
<netdev@xxxxxxxxxxxxxxx>; "open list" <linux-kernel@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH v2 09/13] can: pruss CAN driver.

Hello,

On 02/14/2011 09:45 AM, Subhasish Ghosh wrote:
> That is correct, we receive only pre-programmed CAN ids and "all" or
> "range" implementation is not there in the PRU firmware.

I'd really like to see that you add a "all" implementation to the
firmware. Or even better use the standard id/mask approach.

cheers, Marc

--
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   | 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/