Re: [Patch] idle governor: Avoid lock acquisition to read pm_qosbefore entering idle

[Tim Chen]

On Fri, 2011-02-11 at 13:33 -0600, James Bottomley wrote:
> On Fri, 2011-02-11 at 11:27 -0800, Tim Chen wrote:
> > On Fri, 2011-02-11 at 20:22 +0100, Rafael J. Wysocki wrote:
> > 
> > > 
> > > Thanks, but I'd put that comment before the structure definition with the
> > > "NOTE:" prefix and I think you should explain the reason why that field
> > > shouldn't be changed to 64-bits.
> > > 
> > 
> > Either you or James want to suggest a comment on why the field shouldn't
> > be changed to 64-bits to be placed there?
> 
> /*
>  * Note: The lockless read read path depends on the CPU accessing 
>  * target_value atomically.  Atomic access is only guaranteed on all CPU
>  * types linux supports for 32 bit quantites
>  */
> 
> James
> 
> 

Thanks.  I will incorporate your suggested comment in an updated patch.

Tim


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/