Re: [PATCH 1/4] RTC: Include information about UIE and PIE in RTCdriver proc.

From: Marcelo Roberto Jimenez
Date: Fri Feb 11 2011 - 07:34:51 EST


Hi John,

On Thu, Feb 10, 2011 at 21:06, John Stultz <john.stultz@xxxxxxxxxx> wrote:
>
> This seems to be mostly formatting changes. Are you sure we wont' break
> applications expecting the existing format?

No, I can't be 100% sure, that will depend upon how the application
parses the proc output. The formatting changes are all white space, so
I could remove them. If the value is read using scanf, white spaces
are skipped and the "\t" that were added to make the output pleasant
to the view are not a problem. That part can be reworked if you think
the breakage is serious, it is not really important.

The important thing in the patch are the information additions to the
proc interface: update IRQ enabled, periodic IRQ enabled, periodic IRQ
frequency and max user IRQ frequency. What do you think about these?

> thanks
> -john

Regards,
Marcelo.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/