Re: [RFC] merge 32/64 bits realmode wakeup code

[Rafael J. Wysocki]

On Saturday, January 29, 2011, matthieu castet wrote:
> Rafael J. Wysocki a écrit :
> > On Thursday, January 27, 2011, matthieu castet wrote:
> >> Hi,
> >>
> >> this patch merge 32 and 64 realmode wakeup code :
> >> - this mean less ifdef in code
> >> - we could remove now unused field in wakeup_header (pmode_*)
> >> - this allow to set the first 1 MB NX.
> >>
> >> Do you think it is safe on all X86 32 bit machine ?
> >>
> >> Matthieu
> >>
> >>
> >> Signed-off-by: Matthieu CASTET <castet.matthieu@xxxxxxx>
> > 
> > It _looks_ sane, but it will require some serious testing.  I'm not sure,
> > though, if we can get enough testing coverage without actually committing
> > that change.
> > 
> > How much testing has it received so far?
> > 
> Not too much only qemu with 1 and 2 core and a laptop with 1 cpu.
> 
> Please note that with this patch we can also remove the gdt, idt, ldt stuff from 
> arch/x86/kernel/acpi/wakeup_32.S

That's correct, but those changes can wait.  The most urgent thing is to fix
the resume regression at hand.  I guess we should ask the reporter's in
https://bugzilla.kernel.org/show_bug.cgi?id=27472 to test that patch, right?

Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/