Re: [PATCH -v2 1/3] Fix splitting poisoned THP.

From: Andrea Arcangeli
Date: Fri Jan 28 2011 - 11:17:18 EST


Hello Jin,

On Fri, Jan 28, 2011 at 02:52:48PM +0900, Jin Dongming wrote:
> + /*
> + * FIXME: if splitting THP is failed, it is better
> + * to stop the following operation rather than
> + * causing panic by unmapping. System might survive
> + * if the page is freed later.
> + */

I don't think there would be panic by unmapping. But the page has
already been freed so there's no need to kill anything.

A part from this comment which I'm uncertain about the panic, this new
series looks good to me!

Thanks,
Andrea
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/