Re: [PATCH] virtio_blk: allow re-reading config space at runtime

From: Michael S. Tsirkin
Date: Thu Jan 27 2011 - 10:29:53 EST


On Wed, Jan 19, 2011 at 12:54:01AM +0100, Christoph Hellwig wrote:
> On Wed, Jan 19, 2011 at 09:56:09AM +1030, Rusty Russell wrote:
> > > I don't think we have much choice. We're getting called from irq
> > > context, so we'll need to allocate memory to offload things. That's
> > > unless we keep a thread around that we just need to wake up, which
> > > would be a huge waste of ressources.
> >
> > Yes, but can we keep a workqueue struct around?
>
> We can keep one around, but we can't prevent the virtio core code from
> calling us again while it's still in use.

Yes but in that specific situation (double schedule before
it runs once) discarding one change notification
would not hurt at all.

> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/