Re: [PATCH 04/16] x86: Replace cpu_2_logical_apicid[] with earlypercpu variable

From: Tejun Heo
Date: Mon Jan 24 2011 - 15:04:59 EST


On Mon, Jan 24, 2011 at 11:58:24AM -0800, Yinghai Lu wrote:
> >  DECLARE_EARLY_PER_CPU(u16, x86_cpu_to_apicid);
> >  DECLARE_EARLY_PER_CPU(u16, x86_bios_cpu_apicid);
> > +#if defined(CONFIG_SMP) && defined(CONFIG_X86_32)
> > +DECLARE_EARLY_PER_CPU(int, x86_cpu_to_logical_apicid);
> > +#endif
>
> why changing it from u8 to int?

Because all other apic ids are int. The phys ones are shared with
64bit, so they can't be u8. I thought it would be more consistent
to have int for logicals too.

Thanks.

--
tejun

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/