Re: [PATCH 03/16] x86: Make default_send_IPI_mask_sequence/allbutself_logical()32bit only

[Yinghai Lu]

On Sun, Jan 23, 2011 at 5:37 AM, Tejun Heo <tj@xxxxxxxxxx> wrote:
> Both functions are used only in 32bit.  Put them inside CONFIG_X86_32.
> This is to prepare for logical apicid handling update.
>
> - Cyrill Gorcunov spotted that I forgot to move declarations in ipi.h
>  under CONFIG_X86_32.  Fixed.
>
> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
> Reviewed-by: Pekka Enberg <penberg@xxxxxxxxxx>
> Reviewed-by: Cyrill Gorcunov <gorcunov@xxxxxxxxx>
> ---
>  arch/x86/include/asm/ipi.h |    8 ++++----
>  arch/x86/kernel/apic/ipi.c |    4 ++--
>  2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/x86/include/asm/ipi.h b/arch/x86/include/asm/ipi.h
> index 0b72282..615fa90 100644
> --- a/arch/x86/include/asm/ipi.h
> +++ b/arch/x86/include/asm/ipi.h
> @@ -123,10 +123,6 @@ extern void default_send_IPI_mask_sequence_phys(const struct cpumask *mask,
>                                                 int vector);
>  extern void default_send_IPI_mask_allbutself_phys(const struct cpumask *mask,
>                                                         int vector);
> -extern void default_send_IPI_mask_sequence_logical(const struct cpumask *mask,
> -                                                        int vector);
> -extern void default_send_IPI_mask_allbutself_logical(const struct cpumask *mask,
> -                                                        int vector);
>
>  /* Avoid include hell */
>  #define NMI_VECTOR 0x02
> @@ -150,6 +146,10 @@ static inline void __default_local_send_IPI_all(int vector)
>  }
>
>  #ifdef CONFIG_X86_32
> +extern void default_send_IPI_mask_sequence_logical(const struct cpumask *mask,
> +                                                        int vector);
> +extern void default_send_IPI_mask_allbutself_logical(const struct cpumask *mask,
> +                                                        int vector);
>  extern void default_send_IPI_mask_logical(const struct cpumask *mask,
>                                                 int vector);
>  extern void default_send_IPI_allbutself(int vector);
> diff --git a/arch/x86/kernel/apic/ipi.c b/arch/x86/kernel/apic/ipi.c
> index 08385e0..5037736 100644
> --- a/arch/x86/kernel/apic/ipi.c
> +++ b/arch/x86/kernel/apic/ipi.c
> @@ -56,6 +56,8 @@ void default_send_IPI_mask_allbutself_phys(const struct cpumask *mask,
>        local_irq_restore(flags);
>  }
>
> +#ifdef CONFIG_X86_32
> +
>  void default_send_IPI_mask_sequence_logical(const struct cpumask *mask,
>                                                 int vector)
>  {
> @@ -96,8 +98,6 @@ void default_send_IPI_mask_allbutself_logical(const struct cpumask *mask,
>        local_irq_restore(flags);
>  }
>
> -#ifdef CONFIG_X86_32
> -
>  /*
>  * This is only used on smaller machines.
>  */

Acked-by: Yinghai Lu <yinghai@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/