Re: [PATCH] compaction: don't depend on HUGETLB_PAGE

[Luca Tettamanti]

On Sat, Jan 22, 2011 at 7:38 PM, Andrea Arcangeli <aarcange@xxxxxxxxxx> wrote:
> Hello,
>
> On Sat, Jan 22, 2011 at 03:48:03PM +0100, Luca Tettamanti wrote:
>> Hello Andrea,
>> this commit:
>>
>> commit 5d6892407cab23d4bf2f6de065ca351a53849323
>> Author: Andrea Arcangeli <aarcange@xxxxxxxxxx>
>> Date: Â Thu Jan 13 15:47:07 2011 -0800
>>
>> Â Â thp: select CONFIG_COMPACTION if TRANSPARENT_HUGEPAGE enabled
>>
>> causes this warning during the configuration process:
>>
>> warning: (TRANSPARENT_HUGEPAGE) selects COMPACTION which has unmet
>> direct dependencies (EXPERIMENTAL && HUGETLB_PAGE && MMU)
>>
>> This happens because 'select' does not enable the dependencies of its
>> target, so when I selected THP it also enabled COMPATION but I don't
>> have HUGETLBFS (=HUGETLB_PAGE) enabled.
>> Making THP select HUGETLB_PAGE fixes the warning but I'm not 100% sure
>> that's correct (does it work without HUGETLBFS?).
>
> Mel, what's your take about this issue?
>
> Luca does the below fix all your .config problems?

Yes, no more warnings; I haven't tested the kernel though.

Luca

> diff --git a/mm/Kconfig b/mm/Kconfig
> index 3ad483b..e9c0c61 100644
> --- a/mm/Kconfig
> +++ b/mm/Kconfig
> @@ -179,7 +179,7 @@ config SPLIT_PTLOCK_CPUS
> Âconfig COMPACTION
> Â Â Â Âbool "Allow for memory compaction"
> Â Â Â Âselect MIGRATION
> - Â Â Â depends on EXPERIMENTAL && HUGETLB_PAGE && MMU
> + Â Â Â depends on MMU
> Â Â Â Âhelp
> Â Â Â Â ÂAllows the compaction of memory for the allocation of huge pages.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/