Re: [PATCH] ARM: vexpress: register platform PATA device.

[Russell King - ARM Linux]

On Fri, Jan 07, 2011 at 04:24:05PM -0500, Nick Bowler wrote:
> The compactflash device on this platform is not usable simply because it
> is never registered with the kernel.  Fix that up.
> 
> Signed-off-by: Nick Bowler <nbowler@xxxxxxxxxxxxxxxx>
> ---
>  arch/arm/Kconfig             |    1 +
>  arch/arm/mach-vexpress/v2m.c |   25 +++++++++++++++++++++++++
>  2 files changed, 26 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index d56d21c..ee61039 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -264,6 +264,7 @@ config ARCH_VEXPRESS
>  	select HAVE_CLK
>  	select ICST
>  	select PLAT_VERSATILE
> +	select HAVE_PATA_PLATFORM

To avoid the Kconfig warning, this should be:

	select HAVE_PATA_PLATFORM if ATA

or it needs to be moved outside of the if ATA ... endif block in
drivers/ata/Kconfig.

Apart from that, I see nothing wrong.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/