Re: [PATCH 3/6] x86, NMI: Add priorities to handlers

From: Don Zickus
Date: Fri Jan 07 2011 - 09:43:31 EST


On Fri, Jan 07, 2011 at 02:09:51PM +0100, Peter Zijlstra wrote:
> > static struct event_constraint unconstrained;
> > diff --git a/arch/x86/kernel/kgdb.c b/arch/x86/kernel/kgdb.c
> > index cd21b65..983fb54 100644
> > --- a/arch/x86/kernel/kgdb.c
> > +++ b/arch/x86/kernel/kgdb.c
> > @@ -606,7 +606,7 @@ static struct notifier_block kgdb_notifier = {
> > /*
> > * Lowest-prio notifier priority, we want to be notified last:
> > */
> > - .priority = -INT_MAX,
> > + .priority = NMI_LOCAL_LOW_PRIOR,
> > };
> >
> > /**
>
>
> I had to add the below to make things build here.
>
> ---
> Index: linux-2.6/arch/x86/kernel/kgdb.c
> ===================================================================
> --- linux-2.6.orig/arch/x86/kernel/kgdb.c
> +++ linux-2.6/arch/x86/kernel/kgdb.c
> @@ -48,6 +48,7 @@
> #include <asm/apicdef.h>
> #include <asm/system.h>
> #include <asm/apic.h>
> +#include <asm/nmi.h>
>
> struct dbg_reg_def_t dbg_reg_def[DBG_MAX_REG_NUM] =
> {
>

Doh. I missed a spot. Thanks for the catch. I'll add that and repost.

Cheers,
Don
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/