Re: [PATCH] x86: use PCI method for enabling AMD extended configspace before MSR method

From: Ingo Molnar
Date: Fri Jan 07 2011 - 07:58:40 EST



* Robert Richter <robert.richter@xxxxxxx> wrote:

> On 06.01.11 18:20:04, Robert Richter wrote:
> > On 06.01.11 11:57:35, Jan Beulich wrote:
> > > While both methods should work equivalently well for the native case,
> > > the Xen Dom0 case can't reliably work with the MSR one, since there's
> > > no guarantee that the virtual CPUs it has available fully cover all
> > > necessary physical ones.
> > >
> > > As per the suggestion of Robert Richter the patch only adds the PCI
> > > method, but leaves the MSR one as a fallback to cover new systems the
> > > PCI IDs of which may not have got added to the code base yet.
> > >
> > > Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>
> > > Cc: Robert Richter <robert.richter@xxxxxxx>
> > > Cc: Joerg Roedel <Joerg.Roedel@xxxxxxx>
> > > Cc: Andreas Herrmann <Andreas.Herrmann3@xxxxxxx>
> > > Cc: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
> > >
> > > ---
> > > arch/x86/include/asm/amd_nb.h | 7 ++++++
> > > arch/x86/kernel/amd_nb.c | 7 ++++++
> > > arch/x86/kernel/aperture_64.c | 44 +++++++++++++++---------------------------
> > > arch/x86/pci/amd_bus.c | 30 ++++++++++++++++++++++++++++
> > > 4 files changed, 60 insertions(+), 28 deletions(-)
>
> Btw, the patch should be relative to tip/x86/amd-nb as there would be
> conflicts otherwise due to other changes.

that's upstream meanwhile, so a patch against -git or -tip would suffice.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/