Re: [PATCH] dma: shdma: don't register the global die notifier multiple times

From: Paul Mundt
Date: Thu Jan 06 2011 - 21:01:29 EST


On Thu, Jan 06, 2011 at 06:04:50PM +0100, Guennadi Liakhovetski wrote:
> A recent patch has added a die notifier to the shdma driver, however,
> it registers a static die-notifier object in the probe routine, i.e.,
> for each device instance. This is wrong and leads to a system lockup.
> This patch moves the die notifier registration to module init and
> exit routines respectively.
>
> Reported-by: Magnus Damm <damm@xxxxxxxxxxxxx>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@xxxxxx>
> ---
>
> This fixes the lock up on sh7372. Patch against current sh-2.6/master.
>
Whoops, I suppose I should have tested on a platform with more than one
DMAC :-)

I'll piggyback this on top of the rmobile-latest branch, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/