Re: [PATCH] trace event skb remove duplicate null-pointer check

From: Frederic Weisbecker
Date: Thu Jan 06 2011 - 13:17:38 EST


On Thu, Jan 06, 2011 at 10:15:44AM -0800, David Miller wrote:
> From: Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx>
> Date: Thu, 6 Jan 2011 12:53:19 -0500
>
> > The check for NULL skb in the kfree_skb trace event is a duplicate from the
> > check already done in its only caller, kfree_skb(). Remove this duplicate check.
> >
> > Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx>
> > Acked-by: Neil Horman <nhorman@xxxxxxxxxxxxx>
>
> Acked-by: David S. Miller <davem@xxxxxxxxxxxxx>

May be you want to take that on the net tree? Looks like more appropriate.
Of course this can go through the tracing tree as well.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/