Re: [RFC][PATCH 11/18] sched: Add p->pi_lock to task_rq_lock()

[Peter Zijlstra]

On Wed, 2011-01-05 at 19:46 +0100, Oleg Nesterov wrote:

> One purely cosmetic nit,

Fixed those, thanks!

> Hmm, and normalize_rt_tasks(), it could just do task_rq_lock/task_rq_unlock.
> And why it does read_lock_irqsave(tasklist), btw? _irqsave looks unneeded. 

I'm not quite sure, I think we can make that an RCU iteration of the
taskset as well, no need to even hold the task-lock, it would render the
sysrq button useless in the face of a RT fork bomb, but I'm not sure we
really care about that at all.

Ingo, Thomas?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/