Re: [RFC -v3 PATCH 2/3] sched: add yield_to function

From: Peter Zijlstra
Date: Wed Jan 05 2011 - 12:28:29 EST


On Wed, 2011-01-05 at 19:19 +0200, Avi Kivity wrote:
> On 01/05/2011 07:15 PM, Peter Zijlstra wrote:
> > On Wed, 2011-01-05 at 19:10 +0200, Avi Kivity wrote:
> > > On 01/04/2011 08:04 PM, Peter Zijlstra wrote:
> > > > This definitely wants to be EXPORT_SYMBOL_GPL() and if it were possible
> > > > I'd make it so only kvm.o could use it. It really sucks that kvm is a
> > > > module.
> > >
> > > Why does it suck? I mean apart from the "virtualization is crap" song.
> >
> > Because it needs hooks all over the core kernel, like this yield_to()
> > stuff. Exporting this might lead to others wanting to use it too.
>
> Well, it's very convenient for development (modprobe vs. reboot).

Get a machine that boots fast ;-), it might be because I've never worked
on anything modular, but typically stuff crashes when I got it wrong, in
which case you're forced to power-cycle anyway.

> What hooks do you object to?

Don't really keep a list, but every now and again see something that
makes me think that ought not be exported.

> mmu notifiers are useful for some drivers, sched
> notifiers are useful for cmwq and possibly perf?

Both use explicit function calls because its easier to read the code and
faster.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/