Re: [PATCH 2/3] tracepoint: add __rcu annotation

From: Mathieu Desnoyers
Date: Wed Jan 05 2011 - 09:03:22 EST


* Lai Jiangshan (laijs@xxxxxxxxxxxxxx) wrote:
> Add __rcu annotation to :
> (struct tracepoint)->funcs
>
> signed-off-by: Lai Jiangshan <laijs@xxxxxxxxxxxxxx>

Yep, makes sense!

Thanks,

Acked-by: Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx>

> ---
> diff --git a/include/linux/tracepoint.h b/include/linux/tracepoint.h
> index d3e4f87..e0e400d 100644
> --- a/include/linux/tracepoint.h
> +++ b/include/linux/tracepoint.h
> @@ -32,7 +32,7 @@ struct tracepoint {
> int state; /* State. */
> void (*regfunc)(void);
> void (*unregfunc)(void);
> - struct tracepoint_func *funcs;
> + struct tracepoint_func __rcu *funcs;
> } __attribute__((aligned(32))); /*
> * Aligned on 32 bytes because it is
> * globally visible and gcc happily

--
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/