Re: [PATCH 4/7] perf: Check if HT is supported and enabled

From: Stephane Eranian
Date: Tue Jan 04 2011 - 10:35:19 EST


On Tue, Jan 4, 2011 at 2:58 PM, Peter Zijlstra <a.p.zijlstra@xxxxxxxxx> wrote:
> On Tue, 2011-01-04 at 14:52 +0100, Stephane Eranian wrote:
>>
>> Couldn't you simply over-provision, and then when the CPU is online, use my
>> ht_enabled statement to figure out whether or not you need to handle the sharing
>> issue?
>
> That's pretty much what Lin's latest does:
>
> ÂX86_FEATURE_HT && smp_num_siblings > 1
>
> shows the CPU is capable of HT and will allocate the needed resources.
>
Ok, but once the CPU is online, you can still check whether or not HT is
enabled. If not, then you don't need to bother with the MSR sharing code.
So you may allocate a data structure which you won't use and I think that's
fine given we don't have a good way of figuring out whether HT is enabled
or not.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/