Re: 2.6.37-rc7: Regression: b43: crashes in hwrng_register()

From: Mario 'BitKoenig' Holbe
Date: Tue Jan 04 2011 - 07:20:28 EST


Hello Herbert,

On Tue, Jan 04, 2011 at 03:33:38PM +1100, Herbert Xu wrote:
> Can you please test the following patch?
> diff --git a/drivers/char/hw_random/via-rng.c b/drivers/char/hw_random/via-rng.c

Hmmm, yes - the patch fixes the crashes, i.e. no more crashes with
either sequence of module-loading, cat rng_available works as well,
but...

Having this patch active rngd complains:
rngd[1435]: rngd 2-unofficial-mt.13 starting up...
rngd[1435]: block failed FIPS test: 0x1f
rngd[1435]: block failed FIPS test: 0x1f
...
rngd[1435]: stats: entropy added to kernel pool: 0
rngd[1435]: stats: FIPS 140-2 successes: 0
rngd[1435]: stats: FIPS 140-2 failures: 10

It doesn't do this without the patch.
The only available rng was via, I did blacklist the others just to be
sure.


regards
Mario
--
The social dynamics of the net are a direct consequence of the fact that
nobody has yet developed a Remote Strangulation Protocol. -- Larry Wall

Attachment: signature.asc
Description: Digital signature