Re: [PATCH] regulator: Assign return value of mc13xxx_reg_rmw to ret

From: Yong Shen
Date: Mon Jan 03 2011 - 21:02:32 EST


Acked-by: Yong Shen <yong.shen@xxxxxxxxxx>

On Mon, Jan 3, 2011 at 11:57 PM, Axel Lin <axel.lin@xxxxxxxxx> wrote:
> Otherwise, we will not return error if write to MC13892_SWITCHERS5 failed.
>
> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx>
> ---
>  drivers/regulator/mc13892-regulator.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/regulator/mc13892-regulator.c b/drivers/regulator/mc13892-regulator.c
> index 16a0532..1b8f739 100644
> --- a/drivers/regulator/mc13892-regulator.c
> +++ b/drivers/regulator/mc13892-regulator.c
> @@ -550,7 +550,7 @@ static int __devinit mc13892_regulator_probe(struct platform_device *pdev)
>                if (ret)
>                        goto err_free;
>
> -               mc13xxx_reg_rmw(mc13892, MC13892_SWITCHERS5,
> +               ret = mc13xxx_reg_rmw(mc13892, MC13892_SWITCHERS5,
>                        MC13892_SWITCHERS5_SW3MODE_M |
>                        MC13892_SWITCHERS5_SW4MODE_M,
>                        MC13892_SWITCHERS5_SW3MODE_AUTO |
> --
> 1.7.0.4
>
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/